refactor(issues/KUI-1336): delete CoursePresentaion component and a small refactor in CourseMemo file #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <p className="mb-4"> | ||
| {sectionsLabels.asterisk} {seasonStr(i18n.messages[memoLanguageIndex].extraInfo, validFromTerm)} | ||
| {sectionsLabels.asterisk} {seasonStr(extraInfo, validFromTerm)} | ||
| </p> |
There was a problem hiding this comment.
I realised that we got the data for "extraInfo" in previous steps so I decided to make this a little shorter in case of having cleaner code
ghost
approved these changes
Jun 3, 2024
amirhossein-haerian
changed the title
amirhossein-haerian
changed the title
Sure, I will do that. |
axelbjo
approved these changes
Jun 3, 2024
belanglos
approved these changes
Jun 3, 2024
…small refactor in CourseMemo file
amirhossein-haerian
force-pushed
the
issues/IF-1336
branch
from
ee40ac6 to
4ad2047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task (IF-1336 consists of two parts,
Remove display of text and image in published course PM: for this part I realized that there is a component in the project that handles the display of the section that is meant to be deleted, the name of the component is "Course Presentation".
I have deleted the component and all of the related parts that called it. I also needed to call jest --updateSnapshot to prevent tests to be failed.
Also consider possibly removing code that customizes the printed/pdf version: for this part I have checked how the pdf will be created, I understood that inside the "CourseMemoLinks.js" there is a function for that which simply just calls "window.print()" to create a pdf version of the page. If we want to manage that what should not be in the pdf version of the page we need to use css styles. In our project we have a class called "d-print-none" which mange this and the "Course Presentation" had this className as well. So if we decide to add the text and imge to the PDF later we can simply do it by removing the "d-print-none".