-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use variables as column names #45
Open
ma-z-am
wants to merge
50
commits into
master
Choose a base branch
from
parameters_as_rownames
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"type" allows to specify the output type(s)
Improve get stations
Hopefully this helps decreasing the time required to fix a broken workflow due to changes on the Wasserportal platform
and return early
"station_crosstable_berlin"
Add more tests
or clean existing test files (remove header)
Add more tests
assuming that "start_line:length(textlines)" caused the "argument of length 0" error that occurred during CI
because they may differ when the time difference between two function calls is too big
and improve the readability of the test
and give the names of the corresponding variables in the error message
…n be used by mergeAll()
- add documentation, improve error message - return named vector
- improve error messages - (hopefully) get rid of NA in text output by setting "variable_ids = variable"
and reuse wasserportal_base_url()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variables as list names in merge_raw_results_single(), so they can be used b be used by mergeAll(). Before columns were named with ".x", ".y", etc.
This change is