feat: implemented new pool status which halts if voting power is too …

…high
KYVENetwork · Oct 26, 2023 · 5bf771a · 5bf771a
1 parent c9c105b
commit 5bf771a
Show file tree

Hide file tree

Showing 6 changed files with 102 additions and 55 deletions.
diff --git a/docs/swagger.yml b/docs/swagger.yml
@@ -683,6 +683,7 @@ paths:
                                       - POOL_STATUS_NO_FUNDS
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
+                                      - POOL_STATUS_VP_TOO_HIGH
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -1083,6 +1084,7 @@ paths:
                             - POOL_STATUS_NO_FUNDS
                             - POOL_STATUS_NOT_ENOUGH_DELEGATION
                             - POOL_STATUS_UPGRADING
+                            - POOL_STATUS_VP_TOO_HIGH
                           default: POOL_STATUS_UNSPECIFIED
                       title: >-
                         BasicPool contains the necessary properties need for a
@@ -3949,6 +3951,7 @@ paths:
                                       - POOL_STATUS_NO_FUNDS
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
+                                      - POOL_STATUS_VP_TOO_HIGH
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -4999,6 +5002,7 @@ paths:
                       - POOL_STATUS_NO_FUNDS
                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                       - POOL_STATUS_UPGRADING
+                      - POOL_STATUS_VP_TOO_HIGH
                     default: POOL_STATUS_UNSPECIFIED
                   account:
                     type: string
@@ -5515,6 +5519,7 @@ paths:
                         - POOL_STATUS_NO_FUNDS
                         - POOL_STATUS_NOT_ENOUGH_DELEGATION
                         - POOL_STATUS_UPGRADING
+                        - POOL_STATUS_VP_TOO_HIGH
                       default: POOL_STATUS_UNSPECIFIED
                     account:
                       type: string
@@ -5992,6 +5997,7 @@ paths:
                                 - POOL_STATUS_NO_FUNDS
                                 - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                 - POOL_STATUS_UPGRADING
+                                - POOL_STATUS_VP_TOO_HIGH
                               default: POOL_STATUS_UNSPECIFIED
                         points:
                           type: string
@@ -6421,6 +6427,7 @@ paths:
                                   - POOL_STATUS_NO_FUNDS
                                   - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                   - POOL_STATUS_UPGRADING
+                                  - POOL_STATUS_VP_TOO_HIGH
                                 default: POOL_STATUS_UNSPECIFIED
                           points:
                             type: string
@@ -6962,6 +6969,7 @@ paths:
                                       - POOL_STATUS_NO_FUNDS
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
+                                      - POOL_STATUS_VP_TOO_HIGH
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -7434,6 +7442,7 @@ paths:
                                   - POOL_STATUS_NO_FUNDS
                                   - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                   - POOL_STATUS_UPGRADING
+                                  - POOL_STATUS_VP_TOO_HIGH
                                 default: POOL_STATUS_UNSPECIFIED
                           points:
                             type: string

diff --git a/proto/kyve/pool/v1beta1/pool.proto b/proto/kyve/pool/v1beta1/pool.proto
@@ -22,6 +22,8 @@ enum PoolStatus {
   POOL_STATUS_NOT_ENOUGH_DELEGATION = 4;
   // POOL_STATUS_UPGRADING ...
   POOL_STATUS_UPGRADING = 5;
+  // POOL_STATUS_VP_TOO_HIGH ...
+  POOL_STATUS_VP_TOO_HIGH = 6;
 }
 
 // Protocol holds all info about the current pool version and the

diff --git a/x/bundles/keeper/logic_bundles.go b/x/bundles/keeper/logic_bundles.go
@@ -28,11 +28,29 @@ func (k Keeper) AssertPoolCanRun(ctx sdk.Context, poolId uint64) error {
 		return types.ErrPoolDisabled
 	}
 
+	totalDelegation := uint64(0)
+	maxDelegation := uint64(0)
+
+	// Get the total delegation and the highest delegation of a staker in the pool
+	for _, address := range k.stakerKeeper.GetAllStakerAddressesOfPool(ctx, poolId) {
+		delegation := k.delegationKeeper.GetDelegationAmount(ctx, address)
+		totalDelegation += delegation
+
+		if delegation > maxDelegation {
+			maxDelegation = delegation
+		}
+	}
+
 	// Error if min delegation is not reached
-	if k.delegationKeeper.GetDelegationOfPool(ctx, pool.Id) < pool.MinDelegation {
+	if totalDelegation < pool.MinDelegation {
 		return types.ErrMinDelegationNotReached
 	}
 
+	// Error if the top staker has more than 50%
+	if maxDelegation*2 > totalDelegation {
+		return types.ErrVPTooHigh
+	}
+
 	return nil
 }
 

diff --git a/x/bundles/types/errors.go b/x/bundles/types/errors.go
@@ -23,4 +23,5 @@ var (
 	ErrAlreadyVotedValid       = errors.Register(ModuleName, 1204, "already voted valid on bundle proposal")
 	ErrAlreadyVotedInvalid     = errors.Register(ModuleName, 1205, "already voted invalid on bundle proposal")
 	ErrAlreadyVotedAbstain     = errors.Register(ModuleName, 1206, "already voted abstain on bundle proposal")
+	ErrVPTooHigh               = errors.Register(ModuleName, 1207, "staker in pool has more than 50% voting power")
 )
diff --git a/x/pool/types/pool.pb.go b/x/pool/types/pool.pb.go
diff --git a/x/query/keeper/helper.go b/x/query/keeper/helper.go
@@ -82,7 +82,18 @@ func (k Keeper) GetFullStaker(ctx sdk.Context, stakerAddress string) *types.Full
 }
 
 func (k Keeper) GetPoolStatus(ctx sdk.Context, pool *pooltypes.Pool) pooltypes.PoolStatus {
-	totalDelegation := k.delegationKeeper.GetDelegationOfPool(ctx, pool.Id)
+	totalDelegation := uint64(0)
+	maxDelegation := uint64(0)
+
+	// Get the total delegation and the highest delegation of a staker in the pool
+	for _, address := range k.stakerKeeper.GetAllStakerAddressesOfPool(ctx, pool.Id) {
+		delegation := k.delegationKeeper.GetDelegationAmount(ctx, address)
+		totalDelegation += delegation
+
+		if delegation > maxDelegation {
+			maxDelegation = delegation
+		}
+	}
 
 	var poolStatus pooltypes.PoolStatus
 
@@ -92,6 +103,8 @@ func (k Keeper) GetPoolStatus(ctx sdk.Context, pool *pooltypes.Pool) pooltypes.P
 		poolStatus = pooltypes.POOL_STATUS_DISABLED
 	} else if totalDelegation < pool.MinDelegation {
 		poolStatus = pooltypes.POOL_STATUS_NOT_ENOUGH_DELEGATION
+	} else if maxDelegation*2 > totalDelegation {
+		poolStatus = pooltypes.POOL_STATUS_VP_TOO_HIGH
 	} else if pool.TotalFunds == 0 {
 		poolStatus = pooltypes.POOL_STATUS_NO_FUNDS
 	} else {