feat: implement funders module #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbreithecker
changed the title
# Conflicts: # x/bundles/keeper/keeper_suite_funding_bundles_test.go # x/bundles/keeper/keeper_suite_invalid_bundles_test.go # x/bundles/keeper/keeper_suite_valid_bundles_test.go # x/bundles/keeper/logic_bundles_test.go # x/pool/types/pool.pb.go # x/query/keeper/helper.go
troykessler
reviewed
Nov 7, 2023
mbreithecker
changed the title
mbreithecker
approved these changes
Nov 8, 2023
troykessler
approved these changes
Nov 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: mbreithecker <m@breithecker.de> (cherry picked from commit 0651828)
mbreithecker
pushed a commit
that referenced
this pull request
Nov 8, 2023
mbreithecker
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an improved funders concept as posted in the Commonwealth discussion here.
It features a dedicated funders module where funders maintain their own identities. It allows to specify an exact amount per bundle which should be funded per pool.