feat: make inflation share weight a decimal

CHANGELOG.md

@@ -29,6 +29,7 @@ An '!' indicates a state machine breaking change.
 
 ### Improvements
 
+- ! (`x/pool`) [#190](https://github.com/KYVENetwork/chain/pull/190) Make inflation-share-weight a decimal.
 - [#182](https://github.com/KYVENetwork/chain/pull/182) Make release builds reproducible.
 - ! [#183](https://github.com/KYVENetwork/chain/pull/183) Only charge coins which are whitelisted.
 - ! (deps) [#174](https://github.com/KYVENetwork/chain/pull/174) Add mainnet KYVE image to interchain tests.

app/upgrades/v1_5/upgrade.go

@@ -4,12 +4,15 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/KYVENetwork/chain/app/upgrades/v1_5/v1_4_bundles_types"
+	"github.com/KYVENetwork/chain/app/upgrades/v1_5/v1_4_pool_types"
+	pooltypes "github.com/KYVENetwork/chain/x/pool/types"
+
 	"cosmossdk.io/math"
 
 	storetypes "cosmossdk.io/store/types"
 	upgradetypes "cosmossdk.io/x/upgrade/types"
 
-	"github.com/KYVENetwork/chain/app/upgrades/v1_5/v1_4_types"
 	"github.com/KYVENetwork/chain/x/bundles/keeper"
 	bundlestypes "github.com/KYVENetwork/chain/x/bundles/types"
 	poolkeeper "github.com/KYVENetwork/chain/x/pool/keeper"
@@ -32,6 +35,10 @@ func CreateUpgradeHandler(mm *module.Manager, configurator module.Configurator,
 			return nil, err
 		}
 
+		if err := migrateInflationShareWeight(sdkCtx, poolKeeper, storeKeys, cdc); err != nil {
+			return nil, err
+		}
+
 		// TODO: migrate gov params
 
 		// TODO: migrate fundings
@@ -60,7 +67,7 @@ func migrateStorageCosts(sdkCtx sdk.Context, bundlesKeeper keeper.Keeper, poolKe
 
 	// Copy storage cost from old params to new params
 	// The storage cost of all storage providers will be the same after this migration
-	oldParams := v1_4_types.GetParams(sdkCtx, bundlesStoreKey, cdc)
+	oldParams := v1_4_bundles_types.GetParams(sdkCtx, bundlesStoreKey, cdc)
 	newParams := bundlestypes.Params{
 		UploadTimeout: oldParams.UploadTimeout,
 		StorageCosts: []bundlestypes.StorageCost{
@@ -75,3 +82,81 @@ func migrateStorageCosts(sdkCtx sdk.Context, bundlesKeeper keeper.Keeper, poolKe
 	bundlesKeeper.SetParams(sdkCtx, newParams)
 	return nil
 }
+
+func migrateInflationShareWeight(sdkCtx sdk.Context, poolKeeper *poolkeeper.Keeper, storeKeys []storetypes.StoreKey, cdc codec.Codec) error {
+	var poolStoreKey storetypes.StoreKey
+	for _, k := range storeKeys {
+		if k.Name() == "pool" {
+			poolStoreKey = k
+			break
+		}
+	}
+	if poolStoreKey == nil {
+		return fmt.Errorf("store key not found: pool")
+	}
+
+	pools := v1_4_pool_types.GetAllPools(sdkCtx, poolStoreKey, cdc)
+	for _, pool := range pools {
+		var newPool pooltypes.Pool
+
+		var protocol *pooltypes.Protocol
+		if pool.Protocol != nil {
+			protocol = &pooltypes.Protocol{
+				Version:     pool.Protocol.Version,
+				Binaries:    pool.Protocol.Binaries,
+				LastUpgrade: pool.Protocol.LastUpgrade,
+			}
+		}
+		var upgradePlan *pooltypes.UpgradePlan
+		if pool.UpgradePlan != nil {
+			upgradePlan = &pooltypes.UpgradePlan{
+				Version:     pool.UpgradePlan.Version,
+				Binaries:    pool.UpgradePlan.Binaries,
+				ScheduledAt: pool.UpgradePlan.ScheduledAt,
+				Duration:    pool.UpgradePlan.Duration,
+			}
+		}
+
+		newPool = pooltypes.Pool{
+			Id:             pool.Id,
+			Name:           pool.Name,
+			Runtime:        pool.Runtime,
+			Logo:           pool.Logo,
+			Config:         pool.Config,
+			StartKey:       pool.StartKey,
+			CurrentKey:     pool.CurrentKey,
+			CurrentSummary: pool.CurrentSummary,
+			CurrentIndex:   pool.CurrentIndex,
+			TotalBundles:   pool.TotalBundles,
+			UploadInterval: pool.UploadInterval,
+			// Currently all pools have int64(1_000_000) as inflation_share weight.
+			// Set this to 1 as we now support decimals
+			InflationShareWeight:     math.LegacyMustNewDecFromStr("1"),
+			MinDelegation:            pool.MinDelegation,
+			MaxBundleSize:            pool.MaxBundleSize,
+			Disabled:                 pool.Disabled,
+			Protocol:                 protocol,
+			UpgradePlan:              upgradePlan,
+			CurrentStorageProviderId: pool.CurrentStorageProviderId,
+			CurrentCompressionId:     pool.CurrentCompressionId,
+			EndKey:                   pool.EndKey,
+		}
+		poolKeeper.SetPool(sdkCtx, newPool)
+
+		_ = sdkCtx.EventManager().EmitTypedEvent(&pooltypes.EventPoolUpdated{
+			Id:                   pool.Id,
+			RawUpdateString:      "{\"inflation_share_weight\":\"1.0\"}",
+			Name:                 pool.Name,
+			Runtime:              pool.Runtime,
+			Logo:                 pool.Logo,
+			Config:               pool.Config,
+			UploadInterval:       pool.UploadInterval,
+			InflationShareWeight: math.LegacyMustNewDecFromStr("1"),
+			MinDelegation:        pool.MinDelegation,
+			MaxBundleSize:        pool.MaxBundleSize,
+			StorageProviderId:    pool.CurrentStorageProviderId,
+			CompressionId:        pool.CurrentCompressionId,
+		})
+	}
+	return nil
+}

app/upgrades/v1_5/v1_4_types/getters_params.go → app/upgrades/v1_5/v1_4_bundles_types/getters_params.go

@@ -1,4 +1,4 @@
-package v1_4_types
+package v1_4_bundles_types
 
 import (
 	storeTypes "cosmossdk.io/store/types"

app/upgrades/v1_5/v1_4_pool_types/getters_pool.go

@@ -0,0 +1,25 @@
+package v1_4_pool_types
+
+import (
+	"cosmossdk.io/store/prefix"
+	storetypes "cosmossdk.io/store/types"
+	"github.com/KYVENetwork/chain/x/pool/types"
+	"github.com/cosmos/cosmos-sdk/codec"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+)
+
+// GetAllPools returns all pools
+func GetAllPools(ctx sdk.Context, storeKey storetypes.StoreKey, cdc codec.Codec) (list []Pool) {
+	store := prefix.NewStore(ctx.KVStore(storeKey), types.PoolKey)
+	iterator := storetypes.KVStorePrefixIterator(store, []byte{})
+
+	defer iterator.Close()
+
+	for ; iterator.Valid(); iterator.Next() {
+		var val Pool
+		cdc.MustUnmarshal(iterator.Value(), &val)
+		list = append(list, val)
+	}
+
+	return
+}