chore: remove deprecated delegation module #259
Conversation
mbreithecker
requested review from
troykessler and
christopherbrumm
as code owners
WalkthroughThis change removes the entire delegation module and all related code, configuration, and documentation from the codebase. It eliminates the v2.0 upgrade handler and validator proof verification system, including all associated JSON proof files, scripts, and workflows. The application is updated to use a new v2.1 upgrade handler and store loader, which now deletes the delegation store. All references to the delegation module are removed from application configuration and initialization. Protobuf definitions and CLI commands for delegation are also deleted. The Makefile is updated to reflect version v2.1.0 and a new build timestamp. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant v2_1 Upgrade Handler
participant StoreLoader
App->>v2_1 Upgrade Handler: On upgrade to v2.1, call CreateUpgradeHandler
v2_1 Upgrade Handler->>App: Run module migrations
App->>StoreLoader: Call CreateStoreLoader with upgrade height
StoreLoader->>App: Delete "delegation" store at upgrade
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
17-17: Heading level should increment by one
The "Unreleased" heading jumps from level 1 (#) directly to level 3 (###). For better markdown structure, it should be level 2 (##).- ### Unreleased + ## Unreleased🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
17-17: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3(MD001, heading-increment)
19-19: Add missing determiner in changelog entry
For clarity, prepend “the” to the entry description.- - [#259](https://github.com/KYVENetwork/chain/pull/259) Remove deprecated delegation module. + - [#259](https://github.com/KYVENetwork/chain/pull/259) Remove the deprecated delegation module.🧰 Tools
🪛 LanguageTool
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ....com//pull/259) Remove deprecated delegation module. ### [v2.0.0](https:...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[uncategorized] ~19-~19: You might be missing the article “the” here.
Context: ....com//pull/259) Remove deprecated delegation module. ### [v2.0.0](https:...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
17-17: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Summary
- GitHub Check: test / test
- GitHub Check: lint / golangci
Summary by CodeRabbit
New Features
Refactor
Chores