Arctique #30
Merged
Arctique #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianRei
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Looks good to me. We might want to init the dataset with a path to the full dataset (no train/test/val split, as our goal lmdb file should encompass full arctique with train/test/val split then set via a .csv file which should look like this:
sample_name,train_test_val_split
reg001_A.hdf,test
reg001_B.hdf,test
reg002_A.hdf,train
reg002_B.hdf,train
reg003_A.hdf,valid
reg003_B.hdf,valid
reg004_A.hdf,train
reg004_B.hdf,train
reg005_A.hdf,test
reg005_B.hdf,test
reg006_A.hdf,train
reg006_B.hdf,train
| """ | ||
| Initializes the ArctiqueDataset with the given local path. | ||
| The three PanNuke dataset is located on the /fast file system on the MDC cluster under the path | ||
| '/fast/AG_Kainmueller/synth_unc_models/data/v_review_sample1500_NOISY'. |
|
|
||
| print("LOCAL PATH", local_path) | ||
|
|
||
| self.images_folder = os.path.join(local_path, f'train/images/') |
There was a problem hiding this comment.
maybe, local path is 'full' instead of 'train' and e.g. images_folder is than only 'images/'?
|
|
||
| sample_ID = self.sample_IDs[idx] | ||
|
|
||
| data = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
To add the Arctique dataset to the collection of datasets.
How did you implement your changes?
Torch-dataset that accesses the Arctique data.
How did you test your changes?
pytest-tests or all functions of the dataset-class.
Remaining issues