Conversation
There was a problem hiding this comment.
@Simplyauf The current code has significant limitations as it only returns static values.
-
Implement helper functions for string manipulation, you can see our string lib in case we have some useful functions:
- A function to convert felt252 to a collection (array) of characters
- Functions to search for subsequences within a string
- Functions to extract substrings
-
Revise the parsing approach:
- Analyze the URL to identify standard delimiters (://, /, ?, #)
- Implement logic that actually processes the input and extracts each component
- Handle cases where some components might be missing
-
Include unit tests with different URL formats to verify that each function correctly extracts its component
The current code is a basic skeleton, but it needs an implementation that actually processes the provided input rather than returning hardcoded values.
is it better now kindly check |
coxmars
left a comment
There was a problem hiding this comment.
Hi @Simplyauf please apply those changes and we can merge
|
added |
📝 Pull Request Title
🛠️ Issue
📖 Description
Please provide a general description of your changes. Include any relevant background information or context that may help reviewers understand the purpose of this PR.
🖼️ Screenshots (if applicable)
📝 Additional Notes