fix(Canvas): Duplicated edge IDs #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
fix/duplicated-edge-id
branch
2 times, most recently
from
2e07ed0 to
34c020c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
==========================================
Coverage 78.48% 78.48%
Complexity 367 367
==========================================
Files 468 468
Lines 14777 14778 +1
Branches 2831 2746 -85
==========================================
+ Hits 11598 11599 +1
- Misses 2906 3091 +185
+ Partials 273 88 -185 ☔ View full report in Codecov by Sentry. |
apupier
approved these changes
Jan 8, 2025
Currently, edge IDs are not scoped to the owner flow, causing to be duplicated in case two flows use the same step combination. The fix is to scope the edge ID as well, so we avoid the duplication. fix: KaotoIO#1897
lordrip
force-pushed
the
fix/duplicated-edge-id
branch
from
34c020c to
4f65d05
Compare
|
shivamG640
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, edge IDs are not scoped to the owner flow, causing to be duplicated in case two flows use the same step combination.
Changes
The fix is to scope the edge ID as well, so we avoid duplication.
fix: #1897