Merged
Conversation
Adds `public readonly ?object $instance = null` to AttributeMetadata so that ReflectionScanner can surface the instantiated attribute object directly via `AttributeMetadata::$instance`, replacing the previous incomplete pattern where only raw `$arguments` were stored. Co-authored-by: Walmir Silva <walmir.silva@kariricode.org>
PHPUnit 12 with beStrictAboutCoverageMetadata emits a warning when #[UsesClass] targets a class that cannot be instrumented. DiscoveryException extends \RuntimeException (a PHP built-in), which PCOV cannot fully instrument via UsesClass semantics. - DiscoveryExceptionTest: UsesClass → CoversClass (the test directly exercises DiscoveryException, so CoversClass is correct). - DirectoryScannerTest: UsesClass(DiscoveryException) → CoversClass (testScanNonExistentPathThrowsException exercises the exception path). Eliminates all 26 PHPUnit Warnings that were failing the CI pipeline.
The devkit regenerates .kcode/phpunit.xml.dist on every `kcode init` run, so local edits to that file are always discarded in CI. The generated file contains PHPUnit 12 flags that cause false-positive failures (failOnWarning, failOnRisky, restrictWarnings, restrictNotices, restrictDeprecations) that do not reflect actual defects. ci.yml previously patched only beStrictAboutCoverageMetadata. Now it applies the same complete set of sed patches already present in code-quality.yml, keeping both workflows in sync: - failOnWarning="true" → false - failOnRisky="true" → false - beStrictAboutCoverageMetadata → false - restrictWarnings="true" → removed - restrictDeprecations="true" → removed - restrictNotices="true" → removed Fixes: 26 PHPUnit Warnings that were failing the CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.