Open
Conversation
|
Someone is attempting to deploy a commit to the knox projects Team on Vercel. A member of the Team first needs to authorize it. |
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
petemyron
force-pushed
the
test/fix-padding-tests
branch
3 times, most recently
from
bacc282 to
b4b5c23
Compare
src/stores/editorStore.test.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { describe, it, expect, beforeEach } from "vitest"; | |||
| import { useEditorStore, editorActions, usePadding, useSettings } from "./editorStore"; | |||
| import { useEditorStore, editorActions, usePaddingTop, usePaddingBottom, usePaddingLeft, usePaddingRight, useSettings } from "./editorStore"; | |||
Contributor
There was a problem hiding this comment.
Nit: this import is getting pretty wide; splitting it makes the diff/tests a bit easier to scan.
Suggested change
| import { useEditorStore, editorActions, usePaddingTop, usePaddingBottom, usePaddingLeft, usePaddingRight, useSettings } from "./editorStore"; | |
| import { | |
| useEditorStore, | |
| editorActions, | |
| usePaddingTop, | |
| usePaddingBottom, | |
| usePaddingLeft, | |
| usePaddingRight, | |
| useSettings, | |
| } from "./editorStore"; |
| }); | ||
| }); | ||
|
|
||
| describe("usePadding selector", () => { |
Contributor
There was a problem hiding this comment.
Now that padding is per-side, a table-driven it.each for the selector + transient update cases might be a nice win (less repetition, easier to add coverage for undo/redo on Bottom/Left/Right too).
petemyron
force-pushed
the
test/fix-padding-tests
branch
from
b4b5c23 to
5ef4912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating the use/set padding methods, the tests broke, blocking
pnpm tauri buildfrom completing.