close #KLI-193 配置エリアAでの撮影動作の実装 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizyutyu
approved these changes
Sep 12, 2024
Comment on lines
+92
to
+93
| upload_folder = os.path.join(os.path.dirname(__file__), 'image_data') | ||
| os.makedirs(upload_folder, exist_ok=True) |
There was a problem hiding this comment.
Suggested change
| upload_folder = os.path.join(os.path.dirname(__file__), 'image_data') | |
| os.makedirs(upload_folder, exist_ok=True) | |
| # 画像を保存するファイルが存在しない場合は生成する | |
| upload_folder = os.path.join(os.path.dirname(__file__), 'image_data') | |
| os.makedirs(upload_folder, exist_ok=True) |
Comment on lines
+108
to
+113
| cls = int(objects[0][5]) | ||
| empty_file = os.path.abspath(f"{cls}_skip_camera_action.flag") | ||
|
|
||
| # 空のフラグ管理用ファイルを作成 | ||
| with open(empty_file, 'w') as file: | ||
| pass |
There was a problem hiding this comment.
99行目に# 取得した画像に対し物体検出を行うって書くなら、コメント移動すべきな気がする。コメント内容は好みです。
Suggested change
| cls = int(objects[0][5]) | |
| empty_file = os.path.abspath(f"{cls}_skip_camera_action.flag") | |
| # 空のフラグ管理用ファイルを作成 | |
| with open(empty_file, 'w') as file: | |
| pass | |
| # 検出した分類名フラグ管理用ファイルを作成 | |
| cls = int(objects[0][5]) | |
| cls_name_file = os.path.abspath(f"{cls}_skip_camera_action.flag") | |
| with open(cls_name_file, 'w') as file: | |
| pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チェックリスト
変更点
メモ
競技システムに送る処理がまだありません。すみません。
動作テスト
notionにあります