Fixes #30079 - workaround for ISE when search terms are used #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #30079 |
chris1984
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
ACK, I can search without errors with this patch:
==> /var/log/foreman/production.log <==
2020-09-01T15:37:01 [I|app|4aa77fe7] Started GET "/katello/api/v2/content_views?nondefault=true&organization_id=1&page=1&paged=true&per_page=20&search=+composite+&sort_by=name&sort_order=ASC" for 127.0.0.1 at 2020-09-01 15:37:01 +0000
2020-09-01T15:37:01 [I|app|4aa77fe7] Processing by Katello::Api::V2::ContentViewsController#index as HTML
2020-09-01T15:37:01 [I|app|4aa77fe7] Parameters: {"nondefault"=>"true", "organization_id"=>"1", "page"=>"1", "paged"=>"true", "per_page"=>"20", "search"=>" composite ", "sort_by"=>"name", "sort_order"=>"ASC", "api_version"=>"v2"}
2020-09-01T15:37:01 [I|app|4aa77fe7] Rendering /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.16.0/app/views/katello/api/v2/content_views/index.json.rabl within katello/api/v2/layouts/collection
2020-09-01T15:37:01 [I|app|4aa77fe7] Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.16.0/app/views/katello/api/v2/content_views/index.json.rabl within katello/api/v2/layouts/collection (Duration: 3.9ms | Allocations: 3063)
2020-09-01T15:37:01 [I|app|4aa77fe7] Completed 200 OK in 19ms (Views: 6.3ms | ActiveRecord: 1.6ms | Allocations: 8932)
|
[test katello] |
…true/false expression
jjeffers
force-pushed
the
30079_errata_search
branch
from
bcc5901
to
38fe9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround, not the ultimate resolution, for an observed defect in the scoped_search gem. See this issue for details.
Once that issue is resolved, then the complete_value can be restored.