Add CI/CD pipeline and data export (CSV/JSON) support for BHV #81
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Add admin router with user management endpoints - Create admin service for role-based access control - Add admin dashboard and user gallery templates - Implement admin authentication checks - Add unauthorized access template - Fix JWT configuration and improve token validation - Update gallery to show metadata JSON properly - Add admin navigation and styling - Update tests for new admin functionality
Summary of ChangesHello @safiya2610, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Behavioral Health Vault (BHV) project by establishing a robust, production-ready CI/CD pipeline and introducing versatile data export capabilities. It also fortifies the application's security posture with new authentication mechanisms and middleware, alongside a new admin interface for content management. These changes aim to streamline development, enhance data utility for researchers, and improve the overall user experience and operational readiness of the platform. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements, including a CI/CD pipeline via GitHub Actions and data export functionality in CSV/JSON formats. The changes are well-structured and move the project towards better production readiness. My review focuses on improving reproducibility in the Docker build, correcting some bugs in the new admin and export routes, reducing code duplication, and addressing some minor code quality issues. Overall, this is a great contribution that adds valuable features to the project.
| ) | ||
|
|
||
| matching_users = cur.fetchall() | ||
| print(f"DEBUG: Search query: {q}, Current user: {current_user_email}, Matching users: {matching_users}") |
There was a problem hiding this comment.
This print statement appears to be for debugging. It should be removed or replaced with structured logging (e.g., logger.debug(...)) before merging into a production branch.
| - ./cleaned_data.json:/app/cleaned_data.json | ||
| restart: unless-stopped | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:8000/docs"] |
There was a problem hiding this comment.
The healthcheck in this docker-compose.yml file targets the /docs endpoint. This is inconsistent with the HEALTHCHECK defined in the Dockerfile, which correctly uses the dedicated /health endpoint. The /docs endpoint (Swagger UI) can be disabled in production and is generally heavier than a simple health check. It's better to use the /health endpoint here for consistency and efficiency.
test: ["CMD", "curl", "-f", "http://localhost:8000/health"]
|
@mdxabu I intended this PR to target the |
|
You can change by editing |
|
ok |
|
Done! |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Removed closing img tags that are not required in HTML.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Remove initialization of the neutral emotion set.
2 participants
Overview
This pull request enhances the Behavioral Health Vault (BHV) project by introducing a production-ready CI/CD pipeline and adding support for exporting user data in CSV and JSON formats. These changes align with BHV’s goal of being a minimal, easy-to-install.
Key Changes
Impact
Testing