Add PDF preview #73
Merged
Add PDF preview #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
|
That looks good @ishaanxgupta, Thanks for the contribution. |
|
LGTM |
Should this be implemented for main branch also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #65
Description of your changes:
Added a thumbnail folder so that when we upload pdfs,create the first page of the pdf as a thumbnail to be displayed.
On clicking on the thumbnail so that full pdf can be seeen using iframe.
pdfpreview.demo.mp4
Added this for admin dashboard also
Checklist: