Add plugin: Search in english #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirusu400
commented
May 27, 2022
| }), | ||
| new EditFunction(Search.prototype, "perform").load(str => { | ||
| return plugins.strReplace(str, `return a[1] ? score1 : -Infinity`, | ||
| `return a[1] ? score1 : a[2] ? -9999 : -Infinity` |
Author
There was a problem hiding this comment.
Also on this line, I just return -9999 value if english title is found.
It's a little silly, but it just works right now. Maybe need changed,,
mirusu400
commented
May 27, 2022
Author
There was a problem hiding this comment.
I also add Show Search Result In English Plugins to show english results in search songs.
I want to make it as an Search in english's option, but taiko-web doesn't reload script after changing option (to inject scripts), so I made it an independent script.
I changed it to option, also add search results option for https://github.com/bui/taiko-web/issues/485.
KatieFrogs
force-pushed
the
main
branch
3 times, most recently
from
838c225 to
e5382b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can search in English names
Maybe available todos..
https://github.com/bui/taiko-web/blob/c24b121677d3770e8c7d8c704445fa4f1aa9bfc3/public/src/js/search.js#L102-L172
In these line taiko web supports much search tags but there is no manual about them. (They only shows up on little tooltip on search, but it seems unhelpful. Related issues.
Maybe we can add option on DOM about filtering and make easy to filter songs...