Initial implementation of native kava transfer #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/ibc-precompile
branch
from
bdb1fc8 to
21dad35
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ibc-precompile
branch
from
21dad35 to
2a5324c
Compare
drklee3
reviewed
May 28, 2024
There was a problem hiding this comment.
should value always be sent to the contract addr if it's nonzero? E.g. If specifying value: 100 it should always send the precompile contract 100 - if sender value doesn't decrease by 100 with a successful tx then it should be unexpected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is necessary for implementing
precompile IBC-transfer, low-priority for now