deps: use cosmos-sdk v0.47.10-iavl-v1-kava.1 #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
drklee3 and
evgeniy-scherbina
drklee3
approved these changes
May 28, 2024
previously, v0.47.10-kava.2 used iavl v1, but this version will be retracted because that branch & tag should only be used for iavl v0. this sdk version is the same as v0.47.10-kava.2, but also includes a bug fix to the initial iavl version used when adding new modules see Kava-Labs/cosmos-sdk#545
pirtleshell
force-pushed
the
rp-bump-iavl-v1
branch
from
3d3c3c2 to
1eed05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously,
v0.47.10-kava.2used iavl v1, but this version will be retracted because that branch & tag should only be used for iavl v0.this sdk version uses v1.2.0 of iavl, but also includes a bug fix to the initial iavl version used when adding new modules see Kava-Labs/cosmos-sdk#545
the difference between v1.0.x/v1.1.x & v1.2.x is the use of an internal db type (use a wrapper instead of directly using cosmos-db
Requires merge before Kava-Labs/cosmos-sdk#547 to ensure that CI does not break
i have confirmed the pinned version for internal testnet does not use iavl v1 and will not be affected.