Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

BucketDiscovery: do not spawn new goroutines #70

Closed
nurzhan-saktaganov opened this issue Sep 15, 2024 · 0 comments · Fixed by #72
Closed

BucketDiscovery: do not spawn new goroutines #70

nurzhan-saktaganov opened this issue Sep 15, 2024 · 0 comments · Fixed by #72
Labels
enhancement New feature or request performance

Comments

@nurzhan-saktaganov
Copy link
Collaborator

BucketDiscovery spawns several goroutines and calls on each of them BucketStat.
We can achieve the same behavior without spawning new goroutines, just split BuckerStat into bucketStatAsync and bucketStatWait stages/parts.
nurzhan-saktaganov added a commit that referenced this issue Sep 16, 2024
@nurzhan-saktaganov
resolve issue #70
edc5eb5 
* BucketStat: split into bucketStatAsync and bucketStatWait parts
* BucketDiscovery: do not spawn goroutines, just use futures in the single goroutine
* BucketResolve: make it alias for BucketDiscovery
@nurzhan-saktaganov nurzhan-saktaganov mentioned this issue Sep 16, 2024
Merged
@nurzhan-saktaganov nurzhan-saktaganov linked a pull request Sep 16, 2024 that will close this issue
resolve issue #70 #72
Merged
nurzhan-saktaganov added a commit that referenced this issue Sep 17, 2024
@nurzhan-saktaganov
resolve issue #70
4fd80dc 
* BucketStat: split into bucketStatAsync and bucketStatWait parts
* BucketDiscovery: do not spawn goroutines, just use futures in the single goroutine
* BucketResolve: make it alias for BucketDiscovery
nurzhan-saktaganov added a commit that referenced this issue Sep 17, 2024
@nurzhan-saktaganov
resolve issue #70
8e69721 
* BucketStat: split into bucketStatAsync and bucketStatWait parts
* BucketDiscovery: do not spawn goroutines, just use futures in the single goroutine
* BucketResolve: make it alias for BucketDiscovery
KaymeKaydex pushed a commit that referenced this issue Sep 20, 2024
@nurzhan-saktaganov
resolve issue #70 (#72)
bf100ff
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve issue #70 KaymeKaydex/go-vshard-router
1 participant
@nurzhan-saktaganov