Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

resolve issue #70 #72

Merged
merged 1 commit into from
Sep 20, 2024
Merged

resolve issue #70 #72

merged 1 commit into from
Sep 20, 2024

Conversation

nurzhan-saktaganov
Copy link
Collaborator

  • BucketStat: split into bucketStatAsync and bucketStatWait parts
  • BucketDiscovery: do not spawn goroutines, just use futures in the single goroutine
  • BucketResolve: make it alias for BucketDiscovery

resolves #70

@nurzhan-saktaganov nurzhan-saktaganov linked an issue Sep 16, 2024 that may be closed by this pull request
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_42 branch 2 times, most recently from 8a8d1cc to bcfa2c2 Compare September 17, 2024 11:18
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_70 branch from edc5eb5 to 4fd80dc Compare September 17, 2024 12:03
@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from nsaktaganov_resolve_issue_42 to master September 17, 2024 12:03
@nurzhan-saktaganov nurzhan-saktaganov changed the title WIP: resolve issue #70 resolve issue #70 Sep 17, 2024
@nurzhan-saktaganov nurzhan-saktaganov marked this pull request as ready for review September 17, 2024 12:05
* BucketStat: split into bucketStatAsync and bucketStatWait parts
* BucketDiscovery: do not spawn goroutines, just use futures in the single goroutine
* BucketResolve: make it alias for BucketDiscovery
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_70 branch from 4fd80dc to 8e69721 Compare September 17, 2024 12:06
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (e4e989d) to head (8e69721).

Files with missing lines Patch % Lines
discovery.go 80.00% 3 Missing and 1 partial ⚠️
replicaset.go 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   74.66%   74.88%   +0.22%     
==========================================
  Files          10       10              
  Lines         675      673       -2     
==========================================
  Hits          504      504              
  Misses        123      123              
+ Partials       48       46       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaymeKaydex KaymeKaydex merged commit bf100ff into master Sep 20, 2024
8 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_70 branch September 24, 2024 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BucketDiscovery: do not spawn new goroutines
4 participants