Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

review fixes for #105 #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nurzhan-saktaganov
Copy link
Collaborator

  • ClusterBootstrap: eliminate direct access to r.idToReplicaset
  • replace github links to master branch with permalinks
  • hide router's concurrent data under interface 'routerConcurrentData' to prevent misusage by developers

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_review_fixes_for_105 branch 3 times, most recently from 8783459 to 46ec8ea Compare December 17, 2024 21:32
* ClusterBootstrap: eliminate direct access to r.idToReplicaset
* replace github links to master branch with permalinks
* hide router's concurrent data under interface 'routerConcurrentData' to prevent misusage by developers
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_review_fixes_for_105 branch from 46ec8ea to 6e34cfd Compare December 17, 2024 21:42
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (0a8677f) to head (6e34cfd).

Files with missing lines Patch % Lines
api.go 83.33% 1 Missing ⚠️
discovery.go 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   67.33%   67.31%   -0.03%     
==========================================
  Files          13       14       +1     
  Lines        1344     1343       -1     
==========================================
- Hits          905      904       -1     
  Misses        377      377              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants