Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Fix buckets discovery #23

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix buckets discovery #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
## Unreleased

BUG FIXES:

* Fix buckets discovery (it doesn't freeze now)

## 0.0.11

FEATURES:

* BucketStat has become a public method (#21)

REFACTOR:
Expand All @@ -23,4 +30,4 @@ FEATURES:

REFACTOR:

* refactored place for rs method
* refactored place for rs method
5 changes: 3 additions & 2 deletions discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ func (r *Router) DiscoveryAllBuckets(ctx context.Context) error {
knownBucket.Add(1)
}

// if TotalBucketCount < BUCKET_CHUNK_SIZE then nextFrom equal zero
if rawReq.From == *nextFrom {
// There are no more buckets
// https://github.com/tarantool/vshard/blob/8d299bfe/vshard/storage/init.lua#L1730
if nextFrom == nil || *nextFrom == 0 {
return nil
}

Expand Down
Loading