This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
resolve (fix or suppress) all linter warnings #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurzhan-saktaganov
force-pushed
the
nsaktaganov_linters_fix
branch
from
fade434 to
41b5f98
Compare
nurzhan-saktaganov
changed the title
KaymeKaydex
suggested changes
Aug 26, 2024
nurzhan-saktaganov
added a commit
that referenced
this pull request
Aug 26, 2024
nurzhan-saktaganov
changed the title
* wsl is removed from linters list because produces too many noise
* several linters are enabled because they are usefull: gosimple, staticcheck, fofmt, nilerr and etc
* bugfix: "BucketStat" always returns non-nil err, fixed (found by staticcheck linter),
although this function may need additional fixes.
* bugfix: "DiscoveryAllBuckets" returns nil even if errGr.Wait() returns err, fixed (found by nilerr)
* bugfix: misusage of atomics in "DiscoveryHandleBuckets", fixed (found by govet).
This function does not seem correct yet, it would be discussed in another issue
nurzhan-saktaganov
added a commit
that referenced
this pull request
Aug 26, 2024
nurzhan-saktaganov
force-pushed
the
nsaktaganov_linters_fix
branch
from
ce40bc2 to
dfa730d
Compare
nurzhan-saktaganov
changed the base branch from
nsaktaganov_vshard_storage_call_resp_unpack_fix
to
master
KaymeKaydex
approved these changes
Aug 26, 2024
nurzhan-saktaganov
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
although this function may need additional fixes.
This function does not seem correct yet, it will be discussed in another issue
NOTE: the current branch is implemented over branch nsaktaganov_vshard_storage_call_resp_unpack_fix.
It should be merged only after #35. Don't forget to change the destination branch to master.