This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
resolve issue #36 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nurzhan-saktaganov
commented
Aug 16, 2024
nurzhan-saktaganov
commented
- make the idToReplicaset map immutable by convention
- instead, we create an entirely new object instead of updating the old one
|
need just tests |
nurzhan-saktaganov
force-pushed
the
nsaktaganov_linters_fix
branch
from
ce40bc2 to
dfa730d
Compare
nurzhan-saktaganov
added a commit
that referenced
this pull request
Aug 26, 2024
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_35
branch
from
4362f70 to
1acb936
Compare
nurzhan-saktaganov
changed the base branch from
nsaktaganov_linters_fix
to
master
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_35
branch
2 times, most recently
from
26af8a4 to
7f5c269
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_35
branch
from
7f5c269 to
952adbf
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 21.50% 21.82% +0.32%
==========================================
Files 9 9
Lines 651 678 +27
==========================================
+ Hits 140 148 +8
- Misses 505 524 +19
Partials 6 6 ☔ View full report in Codecov by Sentry. |
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_35
branch
from
952adbf to
8a248b0
Compare
* make the idToReplicaset map immutable by convention we create an entirely new object instead of updating the old one * remove proxy object 'struct controller' * update CHANGELOG.md
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_35
branch
from
8a248b0 to
6b88152
Compare
KaymeKaydex
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.