This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
resolve issue #38 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nurzhan-saktaganov
commented
Aug 22, 2024
nurzhan-saktaganov
commented
- simplify DiscoveryAllBuckets
- get rid of a suspicious if
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_38
branch
from
faa5bf3 to
fd1ae50
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_39
branch
from
9a80119 to
3ca9b83
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_38
branch
from
fd1ae50 to
989d44a
Compare
KaymeKaydex
reviewed
Aug 26, 2024
nurzhan-saktaganov
added a commit
that referenced
this pull request
Aug 26, 2024
nurzhan-saktaganov
added
invalid
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_39
branch
from
3ca9b83 to
c5012fb
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_38
branch
from
28c9833 to
b0ba924
Compare
nurzhan-saktaganov
changed the base branch from
nsaktaganov_resolve_issue_39
to
master
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 30.31% 30.74% +0.42%
==========================================
Files 10 10
Lines 719 709 -10
==========================================
Hits 218 218
+ Misses 487 477 -10
Partials 14 14 ☔ View full report in Codecov by Sentry. |
* simplify DiscoveryAllBuckets: remove a suspicious if * fix warning from linter v1.60.3
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_38
branch
from
62fed9b to
37cc7ee
Compare
KaymeKaydex
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.