This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
resolve issue #46 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nurzhan-saktaganov
commented
Aug 26, 2024
nurzhan-saktaganov
commented
- simplify RouterMapCallRWImpl: don't use errgroup, channels and workers just send a bunch of requests and wait for their results (similar to the lua implementation)
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_46
branch
from
863742d to
e5adb35
Compare
This was referenced Aug 27, 2024
This was
linked to
issues
Aug 27, 2024
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_46
branch
from
e5adb35 to
223e773
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_38
branch
2 times, most recently
from
62fed9b to
37cc7ee
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_46
branch
from
223e773 to
47ebba3
Compare
KaymeKaydex
reviewed
Sep 4, 2024
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_46
branch
from
47ebba3 to
f5505ba
Compare
nurzhan-saktaganov
changed the base branch from
nsaktaganov_resolve_issue_38
to
master
* simplify RouterMapCallRWImpl: don't use errgroup, channels and workers just send a bunch of requests and wait for their results (similar to the lua implementation) * add tests with real tnt for RouterMapCallRWImpl
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_46
branch
from
f5505ba to
7fe4073
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 30.74% 32.93% +2.18%
==========================================
Files 10 10
Lines 709 662 -47
==========================================
Hits 218 218
+ Misses 477 430 -47
Partials 14 14 ☔ View full report in Codecov by Sentry. |
KaymeKaydex
approved these changes
Sep 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.