Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

init/linter: add linter to github workflow jobs #49

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

KaymeKaydex
Copy link
Owner

@KaymeKaydex KaymeKaydex commented Aug 26, 2024

  • i added lint job to github workflows
  • fixed provider creation tests caused by linter

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.50%. Comparing base (1bf4c27) to head (72a38cb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   21.50%   21.50%           
=======================================
  Files           9        9           
  Lines         651      651           
=======================================
  Hits          140      140           
  Misses        505      505           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaymeKaydex
Copy link
Owner Author

#33


- name: golangci-lint
uses: golangci/golangci-lint-action@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never worked with GitHub actions before, but I guess we should run the second iteration only if the first has failed.

https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f

@KaymeKaydex KaymeKaydex merged commit c3e9913 into master Aug 26, 2024
2 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the init/linter branch December 17, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants