This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
fix several issues (partially close #42) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurzhan-saktaganov
force-pushed
the
nsaktaganov_tests_and_bugfixes_7_sep_2024
branch
from
fc2de61 to
a287b91
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_tests_and_bugfixes_7_sep_2024
branch
from
a287b91 to
0035bcc
Compare
nurzhan-saktaganov
changed the base branch from
nsaktganov_tnt_test_coverage_up
to
master
nurzhan-saktaganov
changed the title
nurzhan-saktaganov
force-pushed
the
nsaktaganov_tests_and_bugfixes_7_sep_2024
branch
from
0035bcc to
8284b21
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 32.39% 32.24% -0.15%
==========================================
Files 10 10
Lines 673 676 +3
==========================================
Hits 218 218
- Misses 439 442 +3
Partials 16 16 ☔ View full report in Codecov by Sentry. |
* RouterCallImpl: fix decoding response from storage_ref * RouterCallImpl: fix decoding response from storage_map * BucketDiscovery: check res for nil * BucketStat: decode bsInfo by ptr * Add tnt tests for discovery logic * Add tnt tests for RouterCallImpl * Add tnt tests for RouterMapCallRWImpl * Add tnt tests for topology logic
nurzhan-saktaganov
force-pushed
the
nsaktaganov_tests_and_bugfixes_7_sep_2024
branch
from
8284b21 to
63a87f2
Compare
KaymeKaydex
suggested changes
Sep 13, 2024
| @@ -10,6 +17,9 @@ REFACTOR: | |||
| * resolve issue #46: drastically simplify RouterMapCallRWImpl and added tests with real tnt | |||
| * Use typed nil pointers instead of memory allocation for EmptyMetrics and emptyLogger structs | |||
| * New test for RouterCallImpl (and fix the old one) | |||
| * New tnt tests for discovery logic | |||
There was a problem hiding this comment.
let's make a new block and call it TESTS
KaymeKaydex
approved these changes
Sep 13, 2024
nurzhan-saktaganov
deleted the
nsaktaganov_tests_and_bugfixes_7_sep_2024
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S. coverage is 69.8% now