This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
resolve issue #60 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nurzhan-saktaganov
commented
Sep 12, 2024
nurzhan-saktaganov
commented
- DiscoveryTimeout by default is 1 minute (zero DiscoveryTimeout is not allowed)
- cronDiscovery: make it panic-tolerant
- bugfix: remove defer in for loop
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
630476c to
468788b
Compare
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
468788b to
48e6bae
Compare
nurzhan-saktaganov
changed the base branch from
nsaktaganov_tests_and_bugfixes_7_sep_2024
to
master
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
48e6bae to
db67754
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 32.53% 32.68% +0.15%
==========================================
Files 10 10
Lines 667 673 +6
==========================================
+ Hits 217 220 +3
- Misses 435 438 +3
Partials 15 15 ☔ View full report in Codecov by Sentry. |
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
db67754 to
14fca81
Compare
KaymeKaydex
suggested changes
Sep 14, 2024
nurzhan-saktaganov
added a commit
that referenced
this pull request
Sep 15, 2024
KaymeKaydex
reviewed
Sep 15, 2024
nurzhan-saktaganov
added a commit
that referenced
this pull request
Sep 15, 2024
nurzhan-saktaganov
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
d91c7a6 to
6d2bfea
Compare
KaymeKaydex
reviewed
Sep 17, 2024
- DiscoveryTimeout by default is 1 minute (zero DiscoveryTimeout is not allowed) - cronDiscovery: make it panic-tolerant - bugfix: remove defer in for loop
KaymeKaydex
force-pushed
the
nsaktaganov_resolve_issue_60
branch
from
6d2bfea to
8bf9e83
Compare
KaymeKaydex
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.