Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

resolve issue #44 #67

Merged
merged 1 commit into from
Sep 14, 2024
Merged

resolve issue #44 #67

merged 1 commit into from
Sep 14, 2024

Conversation

nurzhan-saktaganov
Copy link
Collaborator

  • Remove bucketCount field of struct Replicaset

resolves #44

@nurzhan-saktaganov nurzhan-saktaganov added the bug Something isn't working label Sep 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 32.53%. Comparing base (696fc12) to head (de6dd4a).

Files with missing lines Patch % Lines
discovery.go 0.00% 15 Missing ⚠️
vshard.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   32.24%   32.53%   +0.28%     
==========================================
  Files          10       10              
  Lines         676      667       -9     
==========================================
- Hits          218      217       -1     
+ Misses        442      435       -7     
+ Partials       16       15       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Remove bucketCount field of struct Replicaset
Copy link
Owner

@KaymeKaydex KaymeKaydex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now is the time to do it. maybe later we will be able to implement this correctly

@KaymeKaydex KaymeKaydex merged commit c013b51 into master Sep 14, 2024
2 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_44 branch September 17, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An inconsistent value of field bucketCount of struct Replicaset
3 participants