Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PHP 8 support #343

wants to merge 3 commits into from

Conversation

mhucik
Copy link

@mhucik mhucik commented Apr 12, 2022

  • added support for PHP 8
  • update related packages
  • kdyby/console and kdyby/strict-objects have no release for required updates yet, updates are on dev branch
  • tested in production on PHP 7.4 and on PHP 8.0

BC:

Fix:

  • removed em parameter from abstract Kdyby\Doctrine\Console\OrmDelegateCommand. Parameter already defined in all inherited commands
  • \ReflectionClass class used instead of Nette\Reflection\ClassType
  • \ReflectionProperty class used instead of \Nette\Reflection\Property

@alena424
Copy link

can it be merged?

@mhucik
Copy link
Author

mhucik commented Nov 30, 2023

can it be merged?

@alena424

  • first of all this PR and this branch has to be merged and released
  • then I can update this PR and set dependencies to specific release, so they won't be required from branch
  • then this PR can be merged and released

If you need it for your project and you dont want to wait until it will be merged, you can try following steps:

  1. add my forked repository as composer repository source
"repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/mhucik/doctrine"
    }
  ]
  1. Then you should be able to require it in your project composer require kdyby/doctrine:dev-php8-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants