Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Fork Release #16

Merged
merged 11 commits into from
Aug 27, 2024
Merged

Initial Fork Release #16

merged 11 commits into from
Aug 27, 2024

Conversation

Kenneth-Sills
Copy link
Owner

@Kenneth-Sills Kenneth-Sills commented Aug 27, 2024

Makes progress on #10 and #11, though some tasks remain. Once merged, this should automatically create a release and publish it to the NPM package registry.

Because this is a breaking change, I will update the release notes with a migration guide:

Migrating from eslint-config-airbnb-typescript v18.0.0

  1. First and foremost, you will need to change the dependency in package.json from eslint-config-airbnb-typescript to @kesills/eslint-config-airbnb-typescript. This package starts at version 19 for a smooth transition from the original.
  2. If you are using the ESLint patch plugin for bulk suppression, you may need to regenerate your baseline file to account for modified rules.
  3. Because the ESLint Prettier configs do not support @stylistic rules yet, it's likely unwanted formatting errors will start being reported in your project. See this section of the README for options. We plan on providing a better solution in the future, see Add True Flat Configs #14.

I mostly just removed things that aren't needed and then optimized what is.
All files and docs should now point to the new repo.
- Use my script convention for QoL.
- Add commit message linting configs.
- Add git hooks for commit messages and clean pushes.
- Add a minimal Semantic Release configuration (CI vars already set up).
- Added relevant dev dependencies for the above.
Hopefully this works first try, it's my first Github CI!
This was only conventional before, now it's enforced.
See the added documentation for details on how I generated these.

I could have had the modules export `any`, but I like having the validation.
- Remove unneeded eslint annotation.
- Remove type checking skip, in favor of specifying types.
@Kenneth-Sills
Copy link
Owner Author

Here goes nothing. It's nice not having downstream users yet. 😅

@Kenneth-Sills Kenneth-Sills merged commit 2e44098 into main Aug 27, 2024
1 check passed
@Kenneth-Sills Kenneth-Sills deleted the kesills-initial-release branch August 27, 2024 21:06
Copy link

🎉 This issue has been resolved in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Kenneth-Sills
Copy link
Owner Author

For posterity, I had two failed releases initially.

  1. The first was caused by my failure to include access: public in the publishConfig. Subsequently, a 402 was being thrown by NPM as it tried to publish a private package without payment. This was quickly fixed.
  2. The second appears to be an ephemoral access token / rate limiting issue, as I got a 403 simply trying to clone the project from the pipeline, which did not happen previously. This was addressed by simply re-running the pipeline jobs.
    • Since this worked on the second try, I won't spend more time debugging. If it happens again, especially post-release, I will need to manually rollback or complete the release and then I will spend more time figuring out what causes it. The configs look, from a glimpse, fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant