Allow multiple Chart files at once #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, two calls to chparse.load(file) will return two separate Chart files backed by the same instruments dict resulting in a Chart object that may have incorrect values in the instruments. Fix this by making instruments part of each instance instead of a class field.
Owner
|
You realize this hasn't been updated in nearly 3 years? Anyway, if you could add a regression test for this that would be great. If not say so and I'll merge here and do it myself whenever I get around to releasing. |
Author
|
Indeed. I've worked around this in my project by just copying chart to my own class. For my own workflow learning on open source projects, I'll followup on this and write some tests later this week. No sense in putting more on you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, two calls to chparse.load(file) will return two separate Chart files backed by the same instruments dict resulting in a Chart object that may have incorrect values in the instruments.
Fix this by making instruments part of each instance instead of a class field.