Skip to content

Commit

Permalink
Update RuboCop gems.
Browse files Browse the repository at this point in the history
  • Loading branch information
ppostma committed Jan 5, 2024
1 parent 3f3c2ab commit 6cf84cb
Show file tree
Hide file tree
Showing 8 changed files with 52 additions and 49 deletions.
12 changes: 2 additions & 10 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,15 @@ AllCops:
- 'spec/tikkie/api/v1/**/*'
- 'vendor/**/*'

Gemspec/DevelopmentDependencies:
Enabled: false

Layout/LineLength:
Enabled: false


Metrics/AbcSize:
Max: 50

Metrics/BlockLength:
Exclude:
- 'spec/**/*'

Metrics/CyclomaticComplexity:
Max: 11

Expand All @@ -34,16 +31,11 @@ Metrics/MethodLength:
Metrics/PerceivedComplexity:
Max: 10


RSpec/FactoryBot:
Enabled: false

RSpec/ExampleLength:
Max: 12

RSpec/MultipleExpectations:
Max: 8


Style/SafeNavigation:
Enabled: false
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in tikkie-api.gemspec
gemspec

gem 'rubocop', '~> 1.12.0'
gem 'rubocop'
gem 'rubocop-performance'
gem 'rubocop-rake'
gem 'rubocop-rspec'
71 changes: 41 additions & 30 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,26 @@ PATH
GEM
remote: https://rubygems.org/
specs:
addressable (2.8.4)
addressable (2.8.6)
public_suffix (>= 2.0.2, < 6.0)
ast (2.4.2)
crack (0.4.5)
rexml
diff-lcs (1.5.0)
hashdiff (1.0.1)
jwt (2.2.2)
parallel (1.20.1)
parser (3.2.2.1)
hashdiff (1.1.0)
json (2.7.1)
jwt (2.7.1)
language_server-protocol (3.17.0.3)
parallel (1.24.0)
parser (3.2.2.4)
ast (~> 2.4.1)
public_suffix (4.0.7)
racc
public_suffix (5.0.4)
racc (1.7.3)
rainbow (3.1.1)
rake (13.0.1)
regexp_parser (2.8.0)
rexml (3.2.5)
rake (13.1.0)
regexp_parser (2.8.3)
rexml (3.2.6)
rspec (3.12.0)
rspec-core (~> 3.12.0)
rspec-expectations (~> 3.12.0)
Expand All @@ -31,33 +35,40 @@ GEM
rspec-expectations (3.12.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-mocks (3.12.5)
rspec-mocks (3.12.6)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.0)
rubocop (1.12.1)
rspec-support (3.12.1)
rubocop (1.59.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.0.0.0)
parser (>= 3.2.2.4)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.2.0, < 2.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.30.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1)
parser (>= 2.7.1.5)
rubocop-performance (1.10.2)
rubocop (>= 0.90.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rake (0.5.1)
rubocop
rubocop-rspec (2.2.0)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.25.0)
rubocop (~> 1.33)
rubocop-performance (1.20.1)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-ast (>= 1.1.0)
rubocop-rspec (2.26.0)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
ruby-progressbar (1.13.0)
timecop (0.9.6)
unicode-display_width (2.4.2)
webmock (3.18.1)
timecop (0.9.8)
unicode-display_width (2.5.0)
webmock (3.19.1)
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
Expand All @@ -70,7 +81,7 @@ DEPENDENCIES
jwt (>= 1.0)
rake (~> 13.0)
rspec (~> 3.0)
rubocop (~> 1.12.0)
rubocop
rubocop-performance
rubocop-rake
rubocop-rspec
Expand All @@ -79,4 +90,4 @@ DEPENDENCIES
webmock (~> 3.18)

BUNDLED WITH
2.2.19
2.1.4
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
stub_request(:delete, 'https://api.abnamro.com/v2/tikkie/paymentrequestssubscription').to_return(status: 204)

payment_requests_subscription = client.delete
expect(payment_requests_subscription).to be nil
expect(payment_requests_subscription).to be_nil
end
end
end
2 changes: 1 addition & 1 deletion spec/tikkie/api/resources/payment_requests_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
describe '#previous' do
it 'returns nil when no previous page exists' do
previous_page = resource.previous
expect(previous_page).to be nil
expect(previous_page).to be_nil
end
end
end
2 changes: 1 addition & 1 deletion spec/tikkie/api/resources/payment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

describe '#payment_request_token' do
it 'returns the payment request token' do
expect(resource.payment_request_token).to be nil
expect(resource.payment_request_token).to be_nil
end
end

Expand Down
4 changes: 2 additions & 2 deletions spec/tikkie/api/resources/refund_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

describe '#payment_request_token' do
it 'returns the payment request token' do
expect(resource.payment_request_token).to be nil
expect(resource.payment_request_token).to be_nil
end
end

describe '#payment_token' do
it 'returns the payment token' do
expect(resource.payment_token).to be nil
expect(resource.payment_token).to be_nil
end
end

Expand Down
6 changes: 3 additions & 3 deletions spec/tikkie/notification_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
describe '.parse' do
it 'ignores the notification and returns nil' do
notification = described_class.parse(body)
expect(notification).to be nil
expect(notification).to be_nil
end
end
end
Expand All @@ -53,7 +53,7 @@
describe '.parse' do
it 'ignores the notification and returns nil' do
notification = described_class.parse(body)
expect(notification).to be nil
expect(notification).to be_nil
end
end
end
Expand All @@ -64,7 +64,7 @@
describe '.parse' do
it 'ignores the notification and returns nil' do
notification = described_class.parse(body)
expect(notification).to be nil
expect(notification).to be_nil
end
end
end
Expand Down

0 comments on commit 6cf84cb

Please sign in to comment.