Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Action to generate build artifact #381

Merged
merged 8 commits into from
May 13, 2024
Merged

Use Action to generate build artifact #381

merged 8 commits into from
May 13, 2024

Conversation

kentico-ericd
Copy link
Member

@kentico-ericd kentico-ericd commented Jan 17, 2024

Motivation

Removes appveyor references and uses the existing GitHub action to generate a release package for users.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

  1. Check GH action is passing from latest commit, or push a commit with minor change to re-run action
  2. Download "KInspector" artifact from passing action
  3. Extract .zip archive locally
  4. Run KenticoInspector.WebApplication.exe and ensure application runs without errors

@JosefDvorak JosefDvorak self-assigned this May 13, 2024
Copy link
Collaborator

@JosefDvorak JosefDvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfs-88 is known disused account.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/upload-artifact@v3 will be deprecated on November 30th. v4 has breaking changes in syntax:

https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

@JosefDvorak JosefDvorak changed the title Use Action to generate release files Use Action to generate build artifact May 13, 2024
@JosefDvorak JosefDvorak merged commit 20033d6 into Kentico:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants