Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature filter by tags #12

Closed
wants to merge 3 commits into from

Conversation

msharifi99
Copy link

It fixes #4

@msharifi99 msharifi99 requested a review from makma as a code owner October 4, 2019 21:01
@Simply007
Copy link
Contributor

Great work @MSharifi78!

Would it be possible to make the tag filter expandable and collapsed by default? It looks huge on the preview:
https://deploy-preview-12--ems-extension-marketplace.netlify.com/

Or do you think the multiple selection dropdown would be more intuitive?

We are using the marketplace here:
https://devnet.kentico.com/marketplace

@Simply007
Copy link
Contributor

I have found a couple of multiple selection controls

I think that one looks pretty good: https://vue-multiselect.js.org/

But let's wait for an opinion from @makma - tha main maintainer

@makma
Copy link
Contributor

makma commented Oct 14, 2019

I really like https://vue-multiselect.js.org/, in my opinion, it's much more clear, what do you think @MSharifi78 ?

@msharifi99
Copy link
Author

I agree with @makma, it's a popular package with nice API.
I'll use it for tags filter

@makma
Copy link
Contributor

makma commented Oct 14, 2019

Thank you @MSharifi78, I'm looking forward to your updated PR!

@makma
Copy link
Contributor

makma commented Jan 6, 2020

I'm closing this one due to inactivity. Feel free to reopen/submit a new one.

@makma makma closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags Filtering support
3 participants