Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted validation regex #34

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

RichardKalinec
Copy link
Contributor

@RichardKalinec RichardKalinec commented Oct 18, 2018

To relax AMP domain validation, the validation regex was adjusted to allow for adding domains like amp.localhost, amp.sub.domain.com or amp.com/kentico (to support virtual directories). The new regex is taken from https://mathiasbynens.be/demo/url-regex, specifically the one from @diegoperini, as it has the best results in validation.

Fixes #4

EDIT: Related also to #6

To relax AMP domain validation, the validation regex was adjusted to allow for adding domains like amp.localhost, amp.sub.domain.com or amp.com/kentico (to support virtual directories). The new regex is taken from https://mathiasbynens.be/demo/url-regex, specifically the one from @diegoperini, as it has the best results in validation.
@Simply007
Copy link
Contributor

Hello @kentico-timothyf,

could you please take a look at the regular expression if it is OK for you?

@petrsvihlik petrsvihlik requested review from petrsvihlik and removed request for kentico-timothyf October 29, 2018 14:01
@Simply007
Copy link
Contributor

Since the new version of Kentico EMS is being prepared for release. We are going to groom the issue after the release - the 27th of November.

@Simply007
Copy link
Contributor

Hey @RichardKalinec,

we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!

Please fill out your postal address if you are interested.

This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.

Kentico Developer Community

If there’s anything we can do to help, please don’t hesitate to reach out to us at developerscommunity@kentico.com

@manhhungtran manhhungtran self-requested a review December 19, 2018 09:35
@manhhungtran manhhungtran merged commit 99e52a3 into Kentico:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants