Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unset the flash chip's WP pin on erase #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c0d3z3r0
Copy link
Contributor

Usually firmware pulls the WP pin of the flash chip low to protect the flash chip's content. Set it to high during erase/write.

This was required on a Lenovo ThinkVision P40w-20. Found out by reading Realtek RTD Customer Tool communication during erase. Maybe it's generic? I don't know yet

@KerJoe
Copy link
Owner

KerJoe commented Jan 23, 2024

This code is board dependent, it has to be made more generic (allowing to select the GPIO using command line arguments) for me to be able to merge it.

@c0d3z3r0
Copy link
Contributor Author

Yup, that's why it's WIP and I added that comment :-)
The funny thing was that RTDCustomerTool unconditionally sets this GPIO, even when having WP pin changing disabled in the settings... This needs further investigation.

Usually firmware asserts the flash chip's WP pin to protect the its
content. Deassert WP during erase/write operations.

TODO: probably board specific

Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
@c0d3z3r0 c0d3z3r0 force-pushed the for-upstream/wp_pin branch from 49e0dc7 to 0a440f0 Compare January 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants