Update guess checking logic to consider guesses off by <= .51 to be correct #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where the actual price is <$5 and is between two whole dollar amounts (eg $3.49) and the user guesses $3 or $4, both are incorrect. This is because the difference is more than 10% of the guess. In my opinion, this is a poor UX and feels nitpicky. Given that this is how the game has been, I would consider this intentional and it may be controversial to make this change. However, I think that it would improve the game to increase the leniency for guessing in these cases. Feel free to reject the PR though.