Skip to content

[fix] 체크리스트 알림 비정상 동작 이슈 해결 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbg0205 merged 2 commits into from
Jul 11, 2025
Merged

[fix] 체크리스트 알림 비정상 동작 이슈 해결 #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c3f3a
fix: 체크리스트 승인/반려 잘못된 actorName 노출 이슈 (#354)
pbg0205 Jul 11, 2025
9bdfa3a
refactor: 변수명 memberName -> actorName 변경 (#354)
pbg0205 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/kr/mywork/domain/post/listener/PostApprovalNotificationTxListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public void handlePostApprovalAlarmEvent(final PostApprovalNotificationEvent eve

private void saveNotification(final PostApprovalNotificationEvent event) {
notificationService.save(
event.authorId(), event.authorName(), event.postTitle(), event.memberName(), event.memberId(),
event.authorId(), event.authorName(), event.postTitle(), event.actorName(), event.actorId(),
event.targetType(), event.postId(), event.notificationActionType(), event.modifiedAt(), event.projectId(),
event.projectStepId());
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/kr/mywork/domain/post/listener/event/PostApprovalNotificationEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import kr.mywork.domain.notification.model.NotificationActionType;
import kr.mywork.domain.notification.model.TargetType;

public record PostApprovalNotificationEvent(UUID authorId, String authorName, String postTitle, UUID memberId,
String memberName, TargetType targetType, UUID postId,
public record PostApprovalNotificationEvent(UUID authorId, String authorName, String postTitle, UUID actorId,
String actorName, TargetType targetType, UUID postId,
NotificationActionType notificationActionType, LocalDateTime modifiedAt,
UUID projectId, UUID projectStepId) {
}
4 changes: 2 additions & 2 deletions ...ain/java/kr/mywork/domain/project_checklist/listener/CheckListNotificationTxListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ private void saveNotification(final CheckListApprovalNotificationEvent event) {
event.authorId(),
event.authorName(),
event.checkListTitle(),
event.authorName(),
event.memberId(),
event.actorName(),
event.actorId(),
event.targetType(),
event.checkListId(),
event.notificationActionType(),
Expand Down
2 changes: 1 addition & 1 deletion ...kr/mywork/domain/project_checklist/listener/event/CheckListApprovalNotificationEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import kr.mywork.domain.notification.model.TargetType;

public record CheckListApprovalNotificationEvent(UUID authorId, String authorName, String checkListTitle,
String memberName, UUID memberId, TargetType targetType,
String actorName, UUID actorId, TargetType targetType,
UUID checkListId, NotificationActionType notificationActionType,
LocalDateTime modifiedAt, UUID projectId, UUID projectStepId) {

Expand Down
Loading