remove redundant parent lookup when parent guid is empty.

KevinJump · Sep 25, 2023 · e532323 · e532323
1 parent 9801bee
commit e532323
Showing 1 changed file with 23 additions and 16 deletions.
diff --git a/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs b/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs
@@ -341,26 +341,33 @@ protected virtual IEnumerable<uSyncChange> DeserializeBase(TObject item, XElemen
                 var parentNode = info.Element(uSyncConstants.Xml.Parent);
                 if (parentNode != null && parentNode.Attribute(uSyncConstants.Xml.Key).ValueOrDefault(Guid.Empty) != Guid.Empty)
                 {
-                    var parent = FindParent(parentNode, false);
-                    if (parent == null)
+                    if (parentNode.GetKey() == Guid.Empty)
                     {
-                        var friendlyPath = info.Element(uSyncConstants.Xml.Path).ValueOrDefault(string.Empty);
-                        if (!string.IsNullOrWhiteSpace(friendlyPath))
-                        {
-                            logger.LogDebug("Find Parent failed, will search by path {FriendlyPath}", friendlyPath);
-                            parent = FindParentByPath(friendlyPath);
-                        }
-                    }
-
-                    if (parent != null)
-                    {
-                        parentId = parent.Id;
-                        nodePath = CalculateNodePath(item, parent);
-                        nodeLevel = CalculateNodeLevel(item, parent);
+                        logger.LogDebug("Parent is root (-1)");
                     }
                     else
                     {
-                        logger.LogDebug("Unable to find parent but parent node is set in configuration");
+                        var parent = FindParent(parentNode, false);
+                        if (parent == null)
+                        {
+                            var friendlyPath = info.Element(uSyncConstants.Xml.Path).ValueOrDefault(string.Empty);
+                            if (!string.IsNullOrWhiteSpace(friendlyPath))
+                            {
+                                logger.LogDebug("Find Parent failed, will search by path {FriendlyPath}", friendlyPath);
+                                parent = FindParentByPath(friendlyPath);
+                            }
+                        }
+
+                        if (parent != null)
+                        {
+                            parentId = parent.Id;
+                            nodePath = CalculateNodePath(item, parent);
+                            nodeLevel = CalculateNodeLevel(item, parent);
+                        }
+                        else
+                        {
+                            logger.LogDebug("Unable to find parent but parent node is set in configuration");
+                        }
                     }
                 }