introduce method of internal to make other protected and virtual #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KevinJump is there any chance to get this reviewed :)? |
|
Hey @KevinJump I know you were busy with 15.1 release, so as you release it can we look into this pr 🙏 ? and also in releasing 13 patch with notifications? |
|
Yes - but there will be no releases now until next year (we are not releasing close to christmas, for our own sanity). Can look at doing a nightly build if you want to play with it, before then. |
|
that's cool :) i just wanted make sure that one gets merged :) |
|
Actually on second thought, can you have a look for nightly build, it would be great :) as I can than POC changes base on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves #679