Fix memory leaks and improve error handling in req() function #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added curl_easy_cleanup(curl); to free resources after request
2. Changed to 2L (Enforces full hostname verification)
3. Added cleanup before calling error()
4. Properly convert to C-string XorStr("keyauth.win").c_str()
5. Proper Cleanup to Avoid Memory Leaks
Your original function doesn’t call curl_easy_cleanup(), which means CURL resources aren’t freed in case of errors.
this leads to memory leaks if the function is called multiple times (and its already called multiple times) almost every function
in keyAuth library use it.
Stronger SSL Security curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 1); only checks if the SSL certificate exists,
but does not verify the hostname properly.
Change it to curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 2L);
Enforces full hostname verification, preventing MITM attacks
Updated `req()` function declaration in `auth.hpp` to use `const std::string&` for parameters.
|
The KeyAuth owner has been notified of your pull request. Please wait for him to review it. This could take several days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your original function doesn’t call curl_easy_cleanup(), which means CURL resources aren’t freed in case of errors.
this leads to memory leaks if the function is called multiple times (and its already called multiple times) almost every function
in keyAuth library use it.
Stronger SSL Security curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 1); only checks if the SSL certificate exists,
but does not verify the hostname properly.
Change it to curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 2L);
Enforces full hostname verification, preventing MITM attacks