Update to use new actions-utils that is aware of ALL_CHANGED_FILES #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredly
changed the title
jeresig
approved these changes
Aug 4, 2021
| format: 'json' # robust to filenames with spaces | ||
| absolute: true # our tooling expects absolute paths | ||
|
|
||
| # Now we put it on the environment so that it can be |
| @@ -10,24 +10,24 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Run eslint | |||
| uses: Khan/eslint-action@main | |||
| setup: yarn | |||
| uses: Khan/eslint-action@da16c43dd352e1e606c838008e7f25e3bf3fbf97 | |||
There was a problem hiding this comment.
Would we revert this to main once this lands? or...?
There was a problem hiding this comment.
yeah I can change it before landing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See Khan/actions-utils#14
Test plan:
I updated the workflow to set up the ALL_CHANGED_FILES variable. Our other workflows that use eslint-action will want to add those setup steps as well.