Fixing up logic around selecting/deselecting nested labels #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s a bug in label studio where if you use labels for conditional labeling (creating nested labels), and don’t deselect the label you’re on before attempting to label something else, the console will throw a bunch of errors and beachball of death, forcing you to reload the page. Fixing this by not allowing users to select a different top-level label if there are sub-labels already applied. Also not allowing users to remove a top-level label if there are sub-labels since that logically doesn't make sense. Issue: https://khanacademy.atlassian.net/browse/DI-1502 Test plan: - deployed to test; see in action here: https://data-labeling-test.khanacademy.org/projects/298/data?tab=537&page=1
<full summary> Issue: <url or "none"> Test plan: <see below>
<full summary> Issue: <url or "none"> Test plan: <see below>
<full summary> Issue: <url or "none"> Test plan: <see below>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/tags/control/Label.js
Outdated
| if ( | ||
| labels.selectedLabels.length === 1 && | ||
| self.selected && | ||
| labels.selectedLabels[0].value == self.value && |
src/tags/control/Label.js
Outdated
| !labels.selectedLabels[0].alias && // Hack: we only gave sub-labels aliases | ||
| region.labelings.length > 1 | ||
| ) { | ||
| console.log("can't deselect top level label w sub label!") |
dat-boris
approved these changes
Jul 27, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/tags/control/Label.js
Outdated
| !labels.selectedLabels[0].alias && // Hack: we only gave sub-labels aliases | ||
| region.labelings.length > 1 | ||
| ) { | ||
| console.log('can\'t deselect top level label w sub label!') |
khan-actions-bot
pushed a commit
to Khan/label-studio
that referenced
this pull request
Jul 27, 2024
…083bb0e1d58c941cb5ed55b11612efa095fd at Khan/label-studio-frontend#13 Workflow run: https://github.com/Khan/label-studio/actions/runs/10119334387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There’s a bug in label studio where if you use labels for conditional labeling (creating nested labels), and don’t deselect the label you’re on before attempting to label something else, the console will throw a bunch of errors and beachball of death, forcing you to reload the page. Fixing this by not allowing users to select a different top-level label if there are sub-labels already applied. Also not allowing users to remove a top-level label if there are sub-labels since that logically doesn't make sense.
Issue: https://khanacademy.atlassian.net/browse/DI-1502
Test plan: