Skip to content

Fixed validation issues 2.0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanwong05 merged 1 commit into from
Feb 19, 2026
Merged

Fixed validation issues 2.0 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/src/domain/adapters/csv_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def from_dataframe(df: pd.DataFrame) -> dict[str, Course]:

instructor_names = set()
if instructor_name:
instructor_names.add(instructor_name)
instructor_names.add(str(instructor_name))

# Apply validators
for canonical_name, col_def in col_defs.items():
Expand Down Expand Up @@ -145,7 +145,9 @@ def from_dataframe(df: pd.DataFrame) -> list[Enrollment]:
)

# Remove rows with missing required fields
df_clean = df_normalized.dropna(subset=["Student_PIDM", "Course_Reference_Number"])
df_clean = df_normalized.dropna(
subset=["Student_PIDM", "Course_Reference_Number"]
)

# Build Enrollment objects
enrollments = []
Expand Down
3 changes: 2 additions & 1 deletion backend/src/services/schedule/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ async def generate_schedule(
merges = self.dataset_service.get_merges(dataset_id, user_id) or {}

# 3.5 Drop zero-enrollment courses and get updated merges
merges = self.dataset_service.drop_zero_enrollment(dataset_id, user_id)
files = await self.dataset_service.drop_zero_enrollment(dataset_id, user_id)

# 4. Build scheduling dataset and run algorithm
scheduling_dataset = DatasetFactory.from_dataframes_to_scheduling_dataset(
Expand Down Expand Up @@ -332,6 +332,7 @@ def _build_generation_response(
scheduling_dataset,
conflicts_response: dict,
parameters: dict,
merges: dict[str, list[str]],
) -> dict[str, Any]:
"""Build response for generate_schedule endpoint."""
# Count unique students
Expand Down