Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure objects retained for life of MTLCommandBuffer. #2015

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Ensure objects retained for life of MTLCommandBuffer. #2015

merged 1 commit into from
Sep 11, 2023

Conversation

billhollings
Copy link
Contributor

@billhollings billhollings commented Sep 9, 2023 •
edited
Loading

  • vkCmdBlitImage() ensure swizzle texture view is retained for life of MTLCommandBuffer.
  • vkQueuePresentKHR() use MTLCommandBuffer that retains references.
  • Update MoltenVK version to 1.2.6.

Fixes #2014.

@billhollings
Ensure objects retained for life of MTLCommandBuffer.
0ee1522 
- vkCmdBlitImage() ensure swizzle texture view is retained for life
  of MTLCommandBuffer.
- vkQueuePresentKHR() use MTLCommandBuffer that retains references.
- Update MoltenVK version to 1.2.6.
@billhollings billhollings mentioned this pull request Sep 9, 2023
Closed
@cdavis5e
Copy link
Collaborator

/me smacks forehead yet again

How did I miss that?? Anyway, thanks for cleaning up yet another one of the broken parts of my changes. There's still one other part that I know is broken (#2011), but I'm hoping to get to fixing it soon.

@danginsburg
Copy link
Collaborator

LGTM, thanks for the fix!

@billhollings
Copy link
Contributor Author

/me smacks forehead yet again

How did I miss that?? Anyway, thanks for cleaning up yet another one of the broken parts of my changes.

No worries. The CTS tests were actually passing, despite the validation errors. I just cleaned it up.

There's still one other part that I know is broken (#2011), but I'm hoping to get to fixing it soon.

Actually, I'm going through a cleansing phase to clean up a few small bugs right now. I'm planning to have a look at #2011 in the process of that in the next day or two.

@billhollings billhollings merged commit a2d5b25 into KhronosGroup:main Sep 11, 2023
5 checks passed
@hrydgard hrydgard mentioned this pull request Sep 21, 2023
Closed
@billhollings billhollings deleted the mtlcmdbuff-retain-objs branch March 7, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavis5e cdavis5e cdavis5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch vkQueuePresent to use a retainedRefs command buffer?
3 participants
@billhollings @cdavis5e @danginsburg