Misc Cleanup #2025
Merged
Misc Cleanup #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use relaxed atomics where possible - Calling operator= on a refcounted object should not reinitialize the refcount
Nothing used it, and you should always be able to `static_cast<MVKBaseObject*>` for any object without a crazy inheritance tree
It doesn't do anything, and we don't want anyone to think it does something
billhollings
requested changes
Sep 28, 2023
Make everything constexpr, remove direct access to members
It's very easy to accidentally un-const a `const MVKArrayRef<T>`, since ArrayRefs are meant to be passed by value
etang-cw
force-pushed
the
MiscCleanup
branch
from
5b1ab18
to
27f4f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor things I changed while working on other features
You can check the individual commits for details, the biggest one is a modification of MVKArrayRef so you use
MVKArrayRef<const X>instead ofconst MVKArrayRef<X>, as you can't accidentally un-const the former by copying it into a local variable, (which you can do with ArrayRefs, since they don't own their storage)