MVKQueue: Make sure waitIdle waits for all commands to be encoded before enqueuing its own waitUntilCompleted. #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2031 looks possibly related. |
billhollings
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Very nice catch! Thanks for submitting this!
LGTM.
Just going to give @cdavis5e a chance to chime in, before pulling this in.
This was referenced Aug 1, 2024
cdavis5e
approved these changes
Aug 1, 2024
…ore enqueuing its own waitUntilCompleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That seems to be causing mysterious crashes with asynchronous queue submissions. I've been debugging one where it'd crash the encoding thread because we destroyed the swap chain right after calling
vkQueueWaitIdle, and it wasn't done encoding the Present.For what it's worth in my case the bug bisected to f0cb31a.
Ping #2295, possibly others..