Refactor defining MTLPixelFormat and GPU capabilities. #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MVKMTLDeviceCapabilities to encapsulate Metal GPU family capabilities, and use it in MVKPhysicalDevice and MVKPixelFormats to identify GPU capabilities. - Remove all references to MTLGPUFamily and MTLFeatureSet outside MVKMTLDeviceCapabilities. - Blend or select AppleGPU and MacGPU format capabilities. - Simplify MVKPixelFormats::modifyMTLFormatCapabilities() based on MVKMTLDeviceCapabilities. - Add guard code to ensure MTLPixelFormatInvalid & MTLVertexFormatInvalid capabilities are not overwritten by other formats that don't exist on some platforms. - Update MTLPixelFormat capabilities based on latest Metal docs. - Remove some variations tied to very older OS versions, or MTLFeatureSets that have the same GPU family, including setting MSL 2.0 as the earliest supported version. - Enable VkPhysicalDeviceFeatures::vertexPipelineStoresAndAtomics & fragmentStoresAndAtomics on all platforms. - During startup, only log the highest GPU family.
cdavis5e
requested changes
Aug 16, 2024
No worries. Thanks for having a look, and for your feedback.
The changes embodied here in terms of older OS's should be covered by the existing minimums in Do you see anything particular that doesn't get covered by those minimums? |
Must've missed that... |
cdavis5e
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKMTLDeviceCapabilitiesto encapsulate Metal GPU family capabilities, and use it inMVKPhysicalDeviceandMVKPixelFormatsto identify GPU capabilities.MTLGPUFamilyandMTLFeatureSetoutsideMVKMTLDeviceCapabilities.MVKPixelFormats::modifyMTLFormatCapabilities()based onMVKMTLDeviceCapabilities.MTLPixelFormatInvalid&MTLVertexFormatInvalidcapabilities are not overwritten by other formats that don't exist on some platforms.MTLPixelFormatcapabilities based on latest Metal docs.MTLFeatureSetsthat have the same GPU family, including setting MSL 2.0 as the earliest supported version.VkPhysicalDeviceFeatures::vertexPipelineStoresAndAtomics&fragmentStoresAndAtomicson all platforms.Fixes issue #2301.